Bicep Pattern Module Specifications
# | ID | Title | Severity | Persona | Lifecycle |
---|---|---|---|---|---|
1 | SNFR8 | Module Owner(s) GitHub | |||
2 | SNFR20 | GitHub Teams Only | |||
3 | SNFR9 | AVM & PG Teams GitHub Repo Permissions | |||
4 | SNFR10 | MIT Licensing | |||
5 | SNFR11 | Issues Response Times | |||
6 | SNFR12 | Versions Supported | |||
7 | SNFR23 | GitHub Repo Labels | |||
8 | BCPNFR15 | AVM Module Issue template file |
See Specifications for this chapter
A module MUST have an owner that is defined and managed by a GitHub Team in the Azure GitHub organization.
Today this is only Microsoft FTEs, but everyone is welcome to contribute. The module just MUST be owned by a Microsoft FTE (today) so we can enforce and provide the long-term support required by this initiative.
The names for the GitHub teams for each approved module are already defined in the respective Module Indexes . These teams MUST be created (and used) for each module.
All GitHub repositories that AVM module are published from and hosted within MUST only assign GitHub repository permissions to GitHub teams only.
Each module MUST have separate GitHub teams assigned for module owners AND module contributors respectively. These GitHub teams MUST be created in the Azure organization in GitHub.
There MUST NOT be any GitHub repository permissions assigned to individual users.
The names for the GitHub teams for each approved module are already defined in the respective Module Indexes . These teams MUST be created (and used) for each module.
The
@Azure
prefix in the last column of the tables linked above represents the “Azure” GitHub organization all AVM-related repositories exist in. DO NOT include this segment in the team’s name!
Non-FTE / external contributors (subject matter experts that aren’t Microsoft employees) can’t be members of the teams described in this chapter, hence, they won’t gain any extra permissions on AVM repositories, therefore, they need to work in forks.
The naming convention for the GitHub teams MUST follow the below pattern:
<hyphenated module name>-module-owners-<bicep/tf>
- to be assigned as the GitHub repository’sModule Owners
team<hyphenated module name>-module-contributors-<bicep/tf>
- to be assigned as the GitHub repository’sModule Contributors
team
The naming convention for Bicep modules is slightly different than the naming convention for their respective GitHub teams.
Segments:
<hyphenated module name>
== the AVM Module’s name, with each segment separated by dashes, i.e.,avm-res-<resource provider>-<ARM resource type>
module-owners
ormodule-contributors
== the role the GitHub Team is assigned to<bicep/tf>
== the language the module is written in
Examples:
avm-res-compute-virtualmachine-module-owners-bicep
avm-res-compute-virtualmachine-module-contributors-tf
All officially documented module owner(s) MUST be added to the -module-owners-
team. The -module-owners-
team MUST NOT have any other members.
Any additional module contributors whom the module owner(s) agreed to work with MUST be added to the -module-contributors-
team.
Unless explicitly requested and agreed, members of the AVM core team or any PG teams MUST NOT be added to the -module-owners-
or -module-contributors-
teams as permissions for them are granted through the teams described in
SNFR9
.
In case of Bicep modules, permissions to the BRM repository (the repo of the Bicep Registry) are granted via assigning the-module-owners-
and-module-contributors-
teams to parent teams that already have the required level access configured. While it is the module owner’s responsibility to initiate the addition of their teams to the respective parents, only the AVM core team can approve this parent-child relationship.
Module owners MUST create their -module-owners-
and -module-contributors-
teams and as part of the provisioning process, they MUST request the addition of these teams to their respective parent teams (see the table below for details).
GitHub Team Name | Description | Permissions | Permissions granted through | Where to work? |
---|---|---|---|---|
<hyphenated module name>-module-owners-bicep | AVM Bicep Module Owners - <module name> | Write | Assignment to the avm-technical-reviewers-bicep parent team. | Need to work in a fork. |
<hyphenated module name>-module-contributors-bicep | AVM Bicep Module Contributors - <module name> | Triage | avm-module-contributors-bicep parent team. | Need to work in a fork. |
Examples - GitHub teams required for the Bicep resource module of Azure Virtual Network (avm/res/network/virtual-network
):
avm-res-network-virtualnetwork-module-owners-bicep
–> assign to theavm-technical-reviewers-bicep
parent team.avm-res-network-virtualnetwork-module-contributors-bicep
–> assign to theavm-module-contributors-bicep
parent team.
Direct link to create a new GitHub team and assign it to its parent: Create new team
Fill in the values as follows:
- Team name: Following the naming convention described above, use the value defined in the module indexes.
- Description: Follow the guidance above (see the Description column in the table above).
- Parent team: Follow the guidance above (see the Permissions granted through column in the table above).
- Team visibility:
Visible
- Team notifications:
Enabled
As part of the “initial Pull Request” (that publishes the first version of the module), module owners MUST add an entry to the CODEOWNERS
file in the BRM repository (
here
).
Through this approach, the AVM core team will grant review permission to module owners as part of the standard PR review process.
Every CODEOWNERS
entry (line) MUST include the following segments separated by a single whitespace character:
- Path of the module, relative to the repo’s root, e.g.:
/avm/res/network/virtual-network/
- The
-module-owners-
team, with the@Azure/
prefix, e.g.,@Azure/avm-res-network-virtualnetwork-module-owners-bicep
- The GitHub team of the AVM Bicep reviewers, with the
@Azure/
prefix, i.e.,@Azure/avm-module-reviewers-bicep
Example - CODEOWNERS
entry for the Bicep resource module of Azure Virtual Network (avm/res/network/virtual-network
):
/avm/res/network/virtual-network/ @Azure/avm-res-network-virtualnetwork-module-owners-bicep @Azure/avm-module-reviewers-bicep
Module owners MUST assign the -module-owners-
and -module-contributors-
teams the necessary permissions on their Terraform module repository per the guidance below.
GitHub Team Name | Description | Permissions | Permissions granted through | Where to work? |
---|---|---|---|---|
<module name>-module-owners-tf | AVM Terraform Module Owners - <module name> | Admin | Direct assignment to repo | Module owner can decide whether they want to work in a branch local to the repo or in a fork. |
<module name>-module-contributors-tf | AVM Terraform Module Contributors - <module name> | Write | Direct assignment to repo | Need to work in a fork. |
Direct link to create a new GitHub team: Create new team
Fill in the values as follows:
- Team name: Following the naming convention described above, use the value defined in the module indexes.
- Description: Follow the guidance above (see the Description column in the table above).
- Parent team: Do not assign the team to any parent team.
- Team visibility:
Visible
- Team notifications:
Enabled
A module owner MUST make the following GitHub teams in the Azure GitHub organization admins on the GitHub repo of the module in question:
@Azure/avm-core-team-technical-bicep
= AVM Core Team@Azure/bicep-admins
= Bicep PG team
These required GitHub teams are already associated to the BRM repository and have the required permissions.
@Azure/avm-core-team-technical-terraform
= AVM Core Team@Azure/terraform-avm
= Terraform PG
Module owners MUST assign these GitHub teams as admins on the GitHub repo of the module in question.
For detailed steps, please follow this guidance .
A module MUST be published with the MIT License in the Azure GitHub organization.
A module owner MUST respond to logged issues within 3 business days. See Module Support for more information.
Only the latest released version of a module MUST be supported.
For example, if an AVM Resource Module is used in an AVM Pattern Module that was working but now is not. The first step by the AVM Pattern Module owner should be to upgrade to the latest version of the AVM Resource Module test and then if not fixed, troubleshoot and fix forward from the that latest version of the AVM Resource Module onwards.
This avoids AVM Module owners from having to maintain multiple major release versions.
GitHub repositories where modules are held MUST use the below labels and SHOULD not use any additional labels:
To help apply these to a module GitHub repository you can use the below PowerShell script:
As part of the “initial Pull Request” (that publishes the first version of the module), module owners MUST add an entry to the AVM Module Issue template
file in the BRM repository (
here
).
Through this approach, the AVM core team will allow raising a bug or feature request for a module, only after the module gets merged to the BRM repository.
The module name entry MUST be added to the dropdown list with id module-name-dropdown
as an option, in alphabetical order.
Module owners MUST ensure that the module name is added in alphabetical order, to simplify selecting the right module name when raising an AVM module issue.
Example - AVM Module Issue template
module name entry for the Bicep resource module of Azure Virtual Network (avm/res/network/virtual-network
):
- type: dropdown
id: module-name-dropdown
attributes:
label: Module Name
description: Which existing AVM module is this issue related to?
options:
...
- "avm/res/network/virtual-network"
...
# | ID | Title | Severity | Persona | Lifecycle |
---|---|---|---|---|---|
1 | SFR3 | Deployment/Usage Telemetry | |||
2 | SFR4 | Telemetry Enablement Flexibility | |||
3 | SNFR3 | AVM Compliance Tests | |||
4 | BCPFR4 | Telemetry Enablement |
See Specifications for this chapter
We will maintain a set of CSV files in the AVM Central Repo (
Azure/Azure-Verified-Modules
) with the required TelemetryId prefixes to enable checks to utilize this list to ensure the correct IDs are used. To see the formatted content of these CSV files with additional information, please visit the AVM Module Indexes page.These will also be provided as a comment on the module proposal, once accepted, from the AVM core team.
Modules MUST provide the capability to collect deployment/usage telemetry as detailed in Telemetry further.
To highlight that AVM modules use telemetry, an information notice MUST be included in the footer of each module’s README.md
file with the below content. (See more details on this requirement,
here
.)
The ARM deployment name used for the telemetry MUST follow the pattern and MUST be no longer than 64 characters in length: 46d3xbcp.<res/ptn>.<(short) module name>.<version>.<uniqueness>
<res/ptn>
== AVM Resource or Pattern Module<(short) module name>
== The AVM Module’s, possibly shortened, name including the resource provider and the resource type, without;- The prefixes:
avm-res-
- The prefixes:
avm-ptn-
- The prefixes:
<version>
== The AVM Module’s MAJOR.MINOR version (only) with.
(periods) replaced with-
(hyphens), to allow simpler splitting of the ARM deployment name<uniqueness>
== This section of the ARM deployment name is to be used to ensure uniqueness of the deployment name.- This is to cater for the following scenarios:
- The module is deployed multiple times to the same:
- Location/Region
- Scope (Tenant, Management Group,Subscription, Resource Group)
- The module is deployed multiple times to the same:
- This is to cater for the following scenarios:
Due to the 64-character length limit of Azure deployment names, the<(short) module name>
segment has a length limit of 36 characters, so if the module name is longer than that, it MUST be truncated to 36 characters. If any of the semantic version’s segments are longer than 1 character, it further restricts the number of characters that can be used for naming the module.
An example deployment name for the AVM Virtual Machine Resource Module would be: 46d3xbcp.res.compute-virtualmachine.1-2-3.eum3
An example deployment name for a shortened module name would be: 46d3xbcp.res.desktopvirtualization-appgroup.1-2-3.eum3
The telemetry enablement MUST be on/enabled by default, however this MUST be able to be disabled by a module consumer by setting the below parameter/variable value to false
:
- Bicep:
enableTelemetry
- Terraform:
enable_telemetry
Whenever a module references AVM modules that implement the telemetry parameter (e.g., a pattern module that uses AVM resource modules), the telemetry parameter value MUST be passed through to these modules. This is necessary to ensure a consumer can reliably enable & disable the telemetry feature for all used modules.
Modules MUST pass all tests that ensure compliance to AVM specifications. These tests MUST pass before a module version can be published.
Please note these are still under development at this time and will be published and available soon for module owners.
Module owners MUST request a manual GitHub Pull Request review, prior to their first release of version
0.1.0
of their module, from the related GitHub Team:@Azure/avm-core-team-technical-bicep
, OR@Azure/avm-core-team-technical-terraform
.
To comply with specifications outlined in
SFR3
&
SFR4
you MUST incorporate the following code snippet into your modules. Place this code sample in the “top level” main.bicep
file; it is not necessary to include it in any nested Bicep files (child modules).
@description('Optional. Location for all resources.')
param location string = resourceGroup().location
@description('Optional. Enable/Disable usage telemetry for module.')
param enableTelemetry bool = true
#disable-next-line no-deployments-resources
resource avmTelemetry 'Microsoft.Resources/deployments@2024-03-01' = if (enableTelemetry) {
name: take('46d3xbcp.res.compute-virtualmachine.${replace('-..--..-', '.', '-')}.${substring(uniqueString(deployment().name, location), 0, 4)}', 64)
properties: {
mode: 'Incremental'
template: {
'$schema': 'https://schema.management.azure.com/schemas/2019-04-01/deploymentTemplate.json#'
contentVersion: '1.0.0.0'
resources: []
outputs: {
telemetry: {
type: 'String'
value: 'For more information, see https://aka.ms/avm/TelemetryInfo'
}
}
}
}
}
# | ID | Title | Severity | Persona | Lifecycle |
---|---|---|---|---|---|
1 | SFR1 | Preview Services | |||
2 | SFR2 | WAF Aligned | |||
3 | SFR5 | Availability Zones | |||
4 | SFR6 | Data Redundancy | |||
5 | SNFR25 | Resource Naming | |||
6 | PMFR1 | Resource Group Creation | |||
7 | PMNFR1 | Module Naming | |||
8 | PMNFR2 | Use Resource Modules to Build a Pattern Module | |||
9 | PMNFR3 | Use other Pattern Modules to Build a Pattern Module | |||
10 | BCPFR1 | Cross-Referencing Modules | |||
11 | BCPFR2 | Role Assignments Role Definition Mapping | |||
12 | BCPNFR5 | Role Assignments Role Definition Mapping Limits | |||
13 | BCPNFR6 | Role Assignments Role Definition Mapping Compulsory Roles | |||
14 | BCPNFR8 | Code Styling - lower camelCasing | |||
15 | BCPNFR14 | Versioning | |||
16 | BCPNFR17 | Code Styling - Type casting |
See Specifications for this chapter
Modules MAY create/adopt public preview services and features at their discretion.
Preview API versions MAY be used when:
- The resource/service/feature is GA but the only API version available for the GA resource/service/feature is a preview version
- For example, Diagnostic Settings (
Microsoft.Insights/diagnosticSettings
) the latest version of the API available with GA features, like Category Groups etc., is2021-05-01-preview
- Otherwise the latest “non-preview” version of the API SHOULD be used
- For example, Diagnostic Settings (
Preview services and features, SHOULD NOT be promoted and exposed, unless they are supported by the respective PG, and it’s documented publicly.
However, they MAY be exposed at the module owners discretion, but the following rules MUST be followed:
- The description of each of the parameters/variables used for the preview service/feature MUST start with:
- “THIS IS A <PARAMETER/VARIABLE> USED FOR A PREVIEW SERVICE/FEATURE, MICROSOFT MAY NOT PROVIDE SUPPORT FOR THIS, PLEASE CHECK THE PRODUCT DOCS FOR CLARIFICATION”
Modules SHOULD set defaults in input parameters/variables to align to high priority/impact/severity recommendations, where appropriate and applicable, in the following frameworks and resources:
- Well-Architected Framework (WAF)
- Reliability Hub
- Azure Proactive Resiliency Library (APRL)
- Only Product Group (PG) verified
- Microsoft Defender for Cloud (MDFC)
They SHOULD NOT align to these recommendations when it requires an external dependency/resource to be deployed and configured and then associated to the resources in the module.
Alignment SHOULD prioritize best-practices and security over cost optimization, but MUST allow for these to be overridden by a module consumer easily, if desired.
Read the FAQ of What does AVM mean by “WAF Aligned”? for more detailed information and examples.
Modules that deploy zone-redundant resources MUST enable the spanning across as many zones as possible by default, typically all 3.
Modules that deploy zonal resources MUST provide the ability to specify a zone for the resources to be deployed/pinned to. However, they MUST NOT default to a particular zone by default, e.g. 1
in an effort to make the consumer aware of the zone they are selecting to suit their architecture requirements.
For both scenarios the modules MUST expose these configuration options via configurable parameters/variables.
For information on the differences between zonal and zone-redundant services, see Availability zone service and regional support
Modules that deploy resources or patterns that support data redundancy SHOULD enable this to the highest possible value by default, e.g. RA-GZRS
. When a resource or pattern doesn’t provide the ability to specify data redundancy as a simple property, e.g. GRS
etc., then the modules MUST provide the ability to enable data redundancy for the resources or pattern via parameters/variables.
For example, a Storage Account module can simply set the sku.name
property to Standard_RAGZRS
. Whereas a SQL DB or Cosmos DB module will need to expose more properties, via parameters/variables, to allow the specification of the regions to replicate data to as per the consumers requirements.
For information on the data redundancy options in Azure, see Cross-region replication in Azure
Module owners MUST set the default resource name prefix for child, extension, and interface resources to the associated abbreviation for the specific resource as documented in the following CAF article Abbreviation examples for Azure resources , if specified and documented. This reduces the amount of input values a module consumer MUST provide by default when using the module.
For example, a Private Endpoint that is being deployed as part of a resource module, via the mandatory interfaces, MUST set the Private Endpoint’s default name to begin with the prefix of pep-
.
Module owners MUST also provide the ability for these default names, including the prefixes, to be overridden via a parameter/variable if the consumer wishes to.
Furthermore, as per RMNFR2 , Resource Modules MUST not have a default value specified for the name of the primary resource and therefore the name MUST be provided and specified by the module consumer.
The name provided MAY be used by the module owner to generate the rest of the default name for child, extension, and interface resources if they wish to. For example, for the Private Endpoint mentioned above, the full default name that can be overridden by the consumer, MAY be pep-<primary-resource-name>
.
If the resource does not have a documented abbreviation in Abbreviation examples for Azure resources , then the module owner is free to use a sensible prefix instead.
A Pattern Module MAY create Resource Group(s).
Pattern Modules MUST follow the below naming conventions (all lower case):
- Naming convention:
avm/ptn/<hyphenated grouping/category name>/<hyphenated pattern module name>
- Example:
avm/ptn/compute/app-tier-vmss
oravm/ptn/avd-lza/management-plane
oravm/ptn/3-tier/web-app
- Segments:
ptn
defines this as a pattern module<hyphenated grouping/category name>
is a hierarchical grouping of pattern modules by category, with each word separated by dashes, such as:- project name, e.g.,
avd-lza
, - primary resource provider, e.g.,
compute
ornetwork
, or - architecture, e.g.,
3-tier
- project name, e.g.,
<hyphenated pattern module name>
is a term describing the module’s function, with each word separated by dashes, e.g.,app-tier-vmss
= Application Tier VMSS;management-plane
= Azure Virtual Desktop Landing Zone Accelerator Management Plane
- Naming convention:
avm-ptn-<pattern module name>
(Module name for registry)terraform-<provider>-avm-ptn-<pattern module name>
(GitHub repository name to meet registry naming requirements)
- Example:
avm-ptn-apptiervmss
oravm-ptn-avd-lza-managementplane
- Segments:
<provider>
is the logical abstraction of various APIs used by Terraform. In most cases, this is going to beazurerm
orazuread
for resource modules.ptn
defines this as a pattern module<pattern module name>
is a term describing the module’s function, e.g.,apptiervmss
= Application Tier VMSS;avd-lza-managementplane
= Azure Virtual Desktop Landing Zone Accelerator Management Plane
A Pattern Module SHOULD be built from AVM Resources Modules to establish a standardized code base and improve maintainability. If a valid reason exists, a pattern module MAY contain native resources (“vanilla” code) where it’s necessary. A Pattern Module MUST NOT contain references to non-AVM modules.
Valid reasons for not using a Resource Module for a resource required by a Pattern Module include but are not limited to:
- When using a Resource Module would result in hitting scaling limitations and/or would reduce the capabilities of the Pattern Module due to the limitations of Azure Resource Manager.
- Developing a Pattern Module under time constraint, without having all required Resource Modules readily available.
In the latter case, the Pattern Module SHOULD be updated to use the Resource Module when the required Resource Module becomes available, to avoid accumulating technical debt. Ideally, all required Resource Modules SHOULD be developed first, and then leveraged by the Pattern Module.
A Pattern Module MAY contain and be built using other AVM Pattern Modules. A Pattern Module MUST NOT contain references to non-AVM modules.
Module owners MAY cross-references other modules to build either Resource or Pattern modules.
However, they MUST be referenced only by a public registry reference to a pinned version e.g. br/public:avm/[res|ptn|utl]/<publishedModuleName>:>version<
. They MUST NOT use local parent path references to a module e.g. ../../xxx/yyy.bicep
.
Although, child modules, that are children of the primary resources being deployed by the AVM Resource Module, MAY be specified via local child path e.g. child/resource.bicep
.
Modules MUST NOT contain references to non-AVM modules.
Module owners MAY define common RBAC Role Definition names and IDs within a variable to allow consumers to define a RBAC Role Definition by their name rather than their ID, this should be self contained within the module themselves.
However, they MUST use only the official RBAC Role Definition name within the variable and nothing else.
To meet the requirements of BCPFR2 , BCPNFR5 and BCPNFR6 you MUST use the below code sample in your AVM Modules to achieve this.
@description('''Required. You can provide either the display name (note not all roles are supported, check module documentation) of the role definition, or its fully qualified ID in the following format: `/providers/Microsoft.Authorization/roleDefinitions/c2f4ef07-c644-48eb-af81-4b1b4947fb11`.''')
param roleDefinitionIdOrName string
var builtInRbacRoleNames = {
Owner: '/providers/Microsoft.Authorization/roleDefinitions/8e3af657-a8ff-443c-a75c-2fe8c4bcb635'
Contributor: '/providers/Microsoft.Authorization/roleDefinitions/b24988ac-6180-42a0-ab88-20f7382dd24c'
Reader: '/providers/Microsoft.Authorization/roleDefinitions/acdd72a7-3385-48ef-bd42-f606fba81ae7'
'Role Based Access Control Administrator (Preview)': '/providers/Microsoft.Authorization/roleDefinitions/f58310d9-a9f6-439a-9e8d-f62e7b41a168'
'User Access Administrator': '/providers/Microsoft.Authorization/roleDefinitions/18d7d88d-d35e-4fb5-a5c3-7773c20a72d9'
//Other RBAC Role Definitions Names & IDs can be added here as needed for your module
}
var roleDefinitionIdMappedResult = (contains(builtInRbacRoleNames, roleDefinitionIdOrName) ? builtInRbacRoleNames[roleDefinitionIdOrName] : roleDefinitionIdOrName)
resource roleAssignment 'Microsoft.Authorization/roleAssignments@2022-04-01' = {
//Other properties removed for ease of reading
properties: {
roleDefinitionId: roleDefinitionIdMappedResult
//Other properties removed for ease of reading
}
}
As per BCPFR2 , module owners MAY define common RBAC Role Definition names and IDs within a variable to allow consumers to define a RBAC Role Definition by their name rather than their ID.
Module owners SHOULD NOT map every RBAC Role Definition within this variable as it can cause the module to bloat in size and cause consumption issues later when stitched together with other modules due to the 4MB ARM Template size limit.
Therefore module owners SHOULD only map the most applicable and common RBAC Role Definition names for their module and SHOULD NOT exceed 15 RBAC Role Definitions in the variable.
Remember if the RBAC Role Definition name is not included in the variable this does not mean it cannot be declared, used and assigned to an identity via an RBAC Role Assignment as part of a module, as any RBAC Role Definition can be specified via its ID without being in the variable.
Review the Bicep Contribution Guide’s ‘RBAC Role Definition Name Mapping’ section for a code sample to achieve this requirement.
Module owners MUST include the following roles in the variable for RBAC Role Definition names:
- Owner - ID:
8e3af657-a8ff-443c-a75c-2fe8c4bcb635
- Contributor - ID:
b24988ac-6180-42a0-ab88-20f7382dd24c
- Reader - ID:
acdd72a7-3385-48ef-bd42-f606fba81ae7
- User Access Administrator - ID:
18d7d88d-d35e-4fb5-a5c3-7773c20a72d9
- Role Based Access Control Administrator (Preview) - ID:
f58310d9-a9f6-439a-9e8d-f62e7b41a168
Review the Bicep Contribution Guide’s ‘RBAC Role Definition Name Mapping’ section for a code sample to achieve this requirement.
Module owners SHOULD use lower camelCasing for naming the following:
- Parameters
- Variables
- Outputs
- User Defined Types
- Resources (symbolic names)
- Modules (symbolic names)
For example: camelCasingExample
(lowercase first word (entirely), with capital of first letter of all other words and rest of word in lowercase)
To meet
SNFR17
and depending on the changes you make, you may need to bump the version in the version.json
file.
{
"$schema": "https://aka.ms/bicep-registry-module-version-file-schema#",
"version": "0.1",
"pathFilters": [
"./main.json"
]
}
The version
value is in the form of MAJOR.MINOR
. The PATCH version will be incremented by the CI automatically when publishing the module to the Public Bicep Registry once the corresponding pull request is merged. Therefore, contributions that would only require an update of the patch version, can keep the version.json
file intact.
For example, the version
value should be:
0.1
for new modules, so that they can be released asv0.1.0
.1.0
once the module owner signs off the module is stable enough for it’s first Major release ofv1.0.0
.0.x
for all feature updates between the first releasev0.1.0
and the first Major release ofv1.0.0
.
To improve the usability of primitive module properties declared as strings, you SHOULD declare them using a type which better represents them, and apply any required casting in the module on behalf of the user.
For reference, please refer to the following examples:
@allowed([
'false'
'true'
])
param myParameterValue string = 'false'
resource myResource '(...)' = {
(...)
properties: {
myParameter: myParameterValue
}
}
param myParameterValue string = false
resource myResource '(...)' = {
(...)
properties: {
myParameter: string(myParameterValue)
}
}
@allowed([
'1'
'2'
'3'
])
param zones array
resource myResource '(...)' = {
(...)
properties: {
zones: zones
}
}
@allowed([
1
2
3
])
param zones int[]
resource myResource '(...)' = {
(...)
properties: {
zones: map(zones, zone => string(zone))
}
}
# | ID | Title | Severity | Persona | Lifecycle |
---|---|---|---|---|---|
1 | SNFR14 | Data Types | |||
2 | SNFR22 | Parameters/Variables for Resource IDs | |||
3 | PMNFR5 | Parameter/Variable Naming | |||
4 | BCPFR5 | Availability Zones Implementation | |||
5 | BCPNFR1 | Data Types | |||
6 | BCPNFR7 | Parameter Requirement Types |
See Specifications for this chapter
A module SHOULD use either: simple data types. e.g., string, int, bool.
OR
Complex data types (objects, arrays, maps) when the language-compliant schema is defined.
A module parameter/variable that requires a full Azure Resource ID as an input value, e.g. /subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.KeyVault/vaults/{keyVaultName}
, MUST contain ResourceId/resource_id
in its parameter/variable name to assist users in knowing what value to provide at a glance of the parameter/variable name.
Example for the property workspaceId
for the Diagnostic Settings resource. In Bicep its parameter name should be workspaceResourceId
and the variable name in Terraform should be workspace_resource_id
.
workspaceId
is not descriptive enough and is ambiguous as to which ID is required to be input.
Parameter/variable input names SHOULD contain the resource to which they pertain. E.g., virtualMachineSku
/virtualmachine_sku
To implement requirement SFR5 , the following convention SHOULD apply:
In this case, the parameter should be implemented like
@description('Optional. The Availability Zones to place the resources in.')
@allowed([
1
2
3
])
param zones int[] = [
1
2
3
]
resource myResource (...) {
(...)
properties: {
(...)
zones: map(zones, zone => string(zone))
}
}
In this case, the parameter should be implemented using a singular-named zone
parameter of type int
like
@description('Required. The Availability Zone to place the resource in. If set to 0, then Availability Zone is not set.')
@allowed([
0
1
2
3
])
param zone int
resource myResource (...) {
(...)
properties: {
(...)
zones: zone != 0 ? [ string(zone) ] : null
}
}
To simplify the consumption experience for module consumers when interacting with complex data types input parameters, mainly objects and arrays, the Bicep feature of User-Defined Types MUST be used and declared.
User-Defined Types are GA in Bicep as of version v0.21.1, please ensure you have this version installed as a minimum.
User-Defined Types allow intellisense support in supported IDEs (e.g. Visual Studio Code) for complex input parameters using arrays and objects.
While the transition of CARML modules into AVM is complete, retrofitting User-Defined Types for all modules will take a considerable amount of time.
Therefore, the addition of User-Defined Types is currently NOT mandated/enforced. However, past their initial release, all modules MUST implement User-Defined Types prior to the release of their next version.
Modules will have lots of parameters that will differ in their requirement type (required, optional, etc.). To help consumers understand what each parameter’s requirement type is, module owners MUST add the requirement type to the beginning of each parameter’s description. Below are the requirement types with a definition and example for the description decorator:
Parameter Requirement Type | Definition | Example Description Decorator |
---|---|---|
Required | The parameter value must be provided. The parameter does not have a default value and hence the module expects and requires an input. | @description('Required. <PARAMETER DESCRIPTION HERE...>') |
Conditional | The parameter value can be optional or required based on a condition, mostly based on the value provided to other parameters. Should contain a sentence starting with ‘Required if (…).’ to explain the condition. | @description('Conditional. <PARAMETER DESCRIPTION HERE...>') |
Optional | The parameter value is not mandatory. The module provides a default value for the parameter. | @description('Optional. <PARAMETER DESCRIPTION HERE...>') |
Generated | The parameter value is generated within the module and should not be specified as input in most cases. A common example of this is the utcNow() function that is only supported as the input for a parameter value, and not inside a variable. | @description('Generated. <PARAMETER DESCRIPTION HERE...>') |
# | ID | Title | Severity | Persona | Lifecycle |
---|---|---|---|---|---|
1 | SNFR1 | Prescribed Tests | |||
2 | SNFR2 | E2E Testing | |||
3 | SNFR4 | Unit Tests | |||
4 | SNFR5 | Upgrade Tests | |||
5 | SNFR6 | Static Analysis/Linting Tests | |||
6 | SNFR7 | Idempotency Tests | |||
7 | SNFR24 | Testing Child, Extension & Interface Resources | |||
8 | BCPNFR10 | Test Bicep File Naming | |||
9 | BCPNFR11 | Test Tooling | |||
10 | BCPNFR12 | Deployment Test Naming | |||
11 | BCPNFR13 | Test file metadata | |||
12 | BCPNFR16 | Post-deployment tests |
See Specifications for this chapter
Modules MUST use the prescribed tooling and testing frameworks defined in the language specific specs.
Modules MUST implement end-to-end (deployment) testing that create actual resources to validate that module deployments work. In Bicep tests are sourced from the directories in /tests/e2e
. In Terraform, these are in /examples
.
Each test MUST run and complete without user inputs successfully, for automation purposes.
Each test MUST also destroy/clean-up its resources and test dependencies following a run.
It is likely that to complete E2E tests, a number of resources will be required as dependencies to enable the tests to pass successfully. Some examples:
- When testing the Diagnostic Settings interface for a Resource Module, you will need an existing Log Analytics Workspace to be able to send the logs to as a destination.
- When testing the Private Endpoints interface for a Resource Module, you will need an existing Virtual Network, Subnet and Private DNS Zone to be able to complete the Private Endpoint deployment and configuration.
Module owners MUST:
- Create the required resources that their module depends upon in the test file/directory
- They MUST either use:
- Simple/native resource declarations/definitions in their respective IaC language,
OR - Another already published AVM Module that MUST be pinned to a specific published version.
- They MUST NOT use any local directory path references or local copies of AVM modules in their own modules test directory.
- Simple/native resource declarations/definitions in their respective IaC language,
- They MUST either use:
Modules SHOULD implement unit testing to ensure logic and conditions within parameters/variables/locals are performing correctly. These tests MUST pass before a module version can be published.
Unit Tests test specific module functionality, without deploying resources. Used on more complex modules. In Bicep and Terraform these live in tests/unit
.
Modules SHOULD implement upgrade testing to ensure new features are implemented in a non-breaking fashion on non-major releases.
Modules MUST use static analysis, e.g., linting, security scanning (PSRule, tflint, etc.). These tests MUST pass before a module version can be published.
There may be differences between languages in linting rules standards, but the AVM core team will try to close these and bring them into alignment over time.
Modules MUST implement idempotency end-to-end (deployment) testing. E.g. deploying the module twice over the top of itself.
Modules SHOULD pass the idempotency test, as we are aware that there are some exceptions where they may fail as a false-positive or legitimate cases where a resource cannot be idempotent.
For example, Virtual Machine Image names must be unique on each resource creation/update.
Module owners MUST test that child and extension resources and those Bicep or Terreform interface resources that are supported by their modules, are validated in E2E tests as per SNFR2 to ensure they deploy and are configured correctly.
These MAY be tested in a separate E2E test and DO NOT have to be tested in each E2E test.
Module owners MUST name their test .bicep
files in the /tests/e2e/<defaults/waf-aligned/max/etc.>
directories: main.test.bicep
as the test framework (CI) relies upon this name.
Module owners MUST use the below tooling for unit/linting/static/security analysis tests. These are also used in the AVM Compliance Tests.
- PSRule for Azure
- Pester
- Some tests are provided as part of the AVM Compliance Tests, but you are free to also use Pester for your own tests.
Module owners MUST invoke the module in their test using the syntax:
module testDeployment '../../../main.bicep' =
Example 1: Working example with a single deployment
module testDeployment '../../../main.bicep' = {
scope: resourceGroup
name: '${uniqueString(deployment().name, location)}-test-${serviceShort}'
params: {
(...)
}
}
Example 2: Working example using a deployment loop
@batchSize(1)
module testDeployment '../../main.bicep' = [for iteration in [ 'init', 'idem' ]: {
scope: resourceGroup
name: '${uniqueString(deployment().name, location)}-test-${serviceShort}-${iteration}'
params: {
(...)
}
}]
The syntax is used by the ReadMe-generating utility to identify, pull & format usage examples.
By default, the ReadMe-generating utility will create usage examples headers based on each e2e
folder’s name.
Module owners MAY provide a custom name & description by specifying the metadata blocks name
& description
in their main.test.bicep
test files.
For example:
metadata name = 'Using Customer-Managed-Keys with System-Assigned identity'
metadata description = 'This instance deploys the module using Customer-Managed-Keys using a System-Assigned Identity. This required the service to be deployed twice, once as a pre-requisite to create the System-Assigned Identity, and once to use it for accessing the Customer-Managed-Key secret.'
would lead to a header in the module’s readme.md
file along the lines of
### Example 1: _Using Customer-Managed-Keys with System-Assigned identity_
This instance deploys the module using Customer-Managed-Keys using a System-Assigned Identity. This required the service to be deployed twice, once as a pre-requisite to create the System-Assigned Identity, and once to use it for accessing the Customer-Managed-Key secret.
For each test case in the e2e
folder, you can optionally add post-deployment Pester tests that are executed once the corresponding deployment completed and before the removal logic kicks in.
To leverage the feature you MUST:
Use Pester as a test framework in each test file
Name the file with the suffix
"*.tests.ps1"
Place each test file the
e2e
test’s folder or any subfolder (e.g.,e2e/max/myTest.tests.ps1
ore2e/max/tests/myTest.tests.ps1
)Implement an input parameter
TestInputData
in the following way:param ( [Parameter(Mandatory = $false)] [hashtable] $TestInputData = @{} )
Through this parameter you can make use of every output the
main.test.bicep
file returns, as well as the path to the test template file in case you want to extract data from it directly.For example, with an output such as
output resourceId string = testDeployment[1].outputs.resourceId
defined in themain.test.bicep
file, the$TestInputData
would look like:$TestInputData = @{ DeploymentOutputs = @{ resourceId = @{ Type = "String" Value = "/subscriptions/***/resourceGroups/dep-***-keyvault.vaults-kvvpe-rg/providers/Microsoft.KeyVault/vaults/***kvvpe001" } } ModuleTestFolderPath = "/home/runner/work/bicep-registry-modules/bicep-registry-modules/avm/res/key-vault/vault/tests/e2e/private-endpoint" }
A full test file may look like:
# | ID | Title | Severity | Persona | Lifecycle |
---|---|---|---|---|---|
1 | SNFR15 | Automatic Documentation Generation | |||
2 | SNFR16 | Examples/E2E | |||
3 | BCPNFR2 | Module Documentation Generation | |||
4 | BCPNFR3 | Usage Example formats | |||
5 | BCPNFR4 | Parameter Input Examples |
See Specifications for this chapter
README documentation MUST be automatically/programmatically generated. MUST include the sections as defined in the language specific requirements BCPNFR2 , TFNFR2 .
An examples/e2e directory MUST exist to provide named scenarios for module deployment.
This script/tool is currently being developed by the AVM team and will be made available very soon.
Bicep modules documentation MUST be automatically generated via the provided script/tooling from the AVM team, providing the following headings:
- Title
- Description
- Navigation
- Resource Types
- Usage Examples
- Parameters
- Outputs
- Cross-referenced modules
Usage examples for Bicep modules MUST be provided in the following formats:
Bicep file (orchestration module style) -
.bicep
module <resourceName> 'br/public:avm/[res|ptn|utl]/<publishedModuleName>:>version<' = { name: '${uniqueString(deployment().name, location)}-test-<uniqueIdentifier>' params: { (...) } }
JSON / ARM Template Parameter Files -
.json
{ "$schema": "https://schema.management.azure.com/schemas/2019-04-01/deploymentParameters.json#", "contentVersion": "1.0.0.0", "parameters": { (...) } }
The above formats are currently automatically taken & generated from thetests/e2e
tests. It is enough to run theSet-ModuleReadMe
orSet-AVMModule
functions (from theutilities
folder) to update the usage examples in the readme(s).
Bicep Parameter Files (.bicepparam
) are being reviewed and considered by the AVM team for the usability and features at this time and will likely be added in the future.
Bicep modules MAY provide parameter input examples for parameters using the metadata.example
property via the @metadata()
decorator.
Example:
@metadata({
example: 'uksouth'
})
@description('Optional. Location for all resources.')
param location string = resourceGroup().location
@metadata({
example: '''
{
keyName: 'myKey'
keyVaultResourceId: '/subscriptions/11111111-1111-1111-1111-111111111111/resourceGroups/my-rg/providers/Microsoft.KeyVault/vaults/myvault'
keyVersion: '6d143c1a0a6a453daffec4001e357de0'
userAssignedIdentityResourceId '/subscriptions/11111111-1111-1111-1111-111111111111/resourceGroups/my-rg/providers/Microsoft.ManagedIdentity/userAssignedIdentities/myIdentity'
}
'''
})
@description('Optional. The customer managed key definition.')
param customerManagedKey customerManagedKeyType
It is planned that these examples are automatically added to the module readme’s parameter descriptions when running either the Set-ModuleReadMe
or Set-AVMModule
scripts (available in the utilities folder).
# | ID | Title | Severity | Persona | Lifecycle |
---|---|---|---|---|---|
1 | SNFR17 | Semantic Versioning | |||
2 | SNFR18 | Breaking Changes | |||
3 | SNFR19 | Registries Targeted | |||
4 | SNFR21 | Cross Language Collaboration |
See Specifications for this chapter
You cannot specify the patch version for Bicep modules in the public Bicep Registry, as this is automatically incremented by 1 each time a module is published. You can only set the Major and Minor versions.
See the Bicep Contribution Guide for more information.
Modules MUST use semantic versioning (aka semver) for their versions and releases in accordance with: Semantic Versioning 2.0.0
For example all modules should be released using a semantic version that matches this pattern: X.Y.Z
X
== Major VersionY
== Minor VersionZ
== Patch Version
Initially modules MUST be released as version
0.1.0
and incremented via Minor and Patch versions only until the AVM Core Team are confident the AVM specifications are mature enough and appropriate CI test coverage is in place, plus the module owner is happy the module has been “road tested” and is now stable enough for its first Major release of version1.0.0
.Releasing as version0.1.0
initially and only incrementing Minor and Patch versions allows the module owner to make breaking changes more easily and frequently as it’s still not an official Major/Stable release. 👍Until first Major version
1.0.0
is released, given a version numberX.Y.Z
:X
Major version MUST NOT be bumped.Y
Minor version MUST be bumped when introducing breaking changes (which would normally bump Major after1.0.0
release) or feature updates (same as it will be after1.0.0
release).Z
Patch version MUST be bumped when introducing non-breaking, backward compatible bug fixes (same as it will be after1.0.0
release).
A module SHOULD avoid breaking changes, e.g., deprecating inputs vs. removing. If you need to implement changes that cause a breaking change, the major version should be increased.
Modules that have not been released as1.0.0
may introduce breaking changes, as explained in the previous ID SNFR17 . That means that you have to introduce non-breaking and breaking changes with a minor version jump, as long as the module has not reached version1.0.0
.
There are, however, scenarios where you want to include breaking changes into a commit and not create a new major version. If you want to introduce breaking changes as part of a minor update, you can do so. In this case, it is essential to keep the change backward compatible, so that the existing code will continue to work. At a later point, another update can increase the major version and remove the code introduced for the backward compatibility.
See the language specific examples to find out how you can deal with deprecations in AVM modules.
Modules MUST be published to their respective language public registries.
- Bicep =
Bicep Public Module Registry
- Within the
avm
directory
- Within the
- Terraform = HashiCorp Terraform Registry
When the module owners of the same Resource or Pattern AVM module are not the same individual or team for all languages, each languages team SHOULD collaborate with their sibling language team for the same module to ensure consistency where possible.